Skip to content

[python_flask] Add correctness check for Flask #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
KowalskiThomas merged 1 commit into from
Jan 12, 2026
Merged

[python_flask] Add correctness check for Flask #69

KowalskiThomas merged 1 commit into from
Jan 12, 2026
+121 −0

Conversation

@KowalskiThomas
Copy link
Contributor

@KowalskiThomas KowalskiThomas commented Dec 24, 2025 •
edited
Loading

What is this PR?

This PR adds a very simple correctness check for a Flask app.

In order to create load and use CPU, the script has both a Flask app and a separate "Requester" Thread that makes requests to the app, then issues a special request after a few seconds to ask it to exit and end the process.

@KowalskiThomas KowalskiThomas force-pushed the kowalski/python_gunicorn-initial-commit branch from d439b61 to f5861e8 Compare December 29, 2025 09:26
@KowalskiThomas KowalskiThomas force-pushed the kowalski/python_flask-initial-commit branch from 938ab9f to dc0ddc3 Compare December 29, 2025 09:26
@KowalskiThomas KowalskiThomas force-pushed the kowalski/python_gunicorn-initial-commit branch from f5861e8 to 1bb9fca Compare December 30, 2025 11:25
@KowalskiThomas KowalskiThomas force-pushed the kowalski/python_flask-initial-commit branch 2 times, most recently from f0ffaac to 10e6d51 Compare December 30, 2025 14:14
@KowalskiThomas KowalskiThomas force-pushed the kowalski/python_gunicorn-initial-commit branch from 1bb9fca to eccc269 Compare January 2, 2026 09:01
@KowalskiThomas KowalskiThomas force-pushed the kowalski/python_flask-initial-commit branch from 10e6d51 to ce321d4 Compare January 2, 2026 09:03
@KowalskiThomas KowalskiThomas changed the base branch from kowalski/python_gunicorn-initial-commit to main January 2, 2026 09:03
@KowalskiThomas KowalskiThomas changed the title [python_flask] Initial commit [python_flask] Add correctness check for Flask Jan 8, 2026
r1viollet
r1viollet previously approved these changes Jan 9, 2026
View reviewed changes
Copy link
Collaborator

@r1viollet r1viollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KowalskiThomas KowalskiThomas force-pushed the kowalski/python_flask-initial-commit branch from ce321d4 to 9156761 Compare January 9, 2026 09:17
@KowalskiThomas KowalskiThomas requested a review from a team as a code owner January 9, 2026 09:17
@KowalskiThomas KowalskiThomas force-pushed the kowalski/python_flask-initial-commit branch from 9156761 to 84e4d65 Compare January 9, 2026 09:21
@KowalskiThomas KowalskiThomas force-pushed the kowalski/python_flask-initial-commit branch from 84e4d65 to b4428d2 Compare January 9, 2026 09:21
@r1viollet
Copy link
Collaborator

r1viollet commented Jan 9, 2026 

    pprof_analysis.go:650: Found a profile duration of 10.6 seconds (in profiles.9.1.pprof)
    pprof_analysis.go:296: Results stored in  /home/runner/work/prof-correctness/prof-correctness/data/python_uwsgi_3.11-20260109-092515-1080165008/profiles.9.1.json
    pprof_analysis.go:442: Assertion failed: stack '.*_make_requests.*' (labels=[{thread name [Requester] }]) should have been 33% +/- 5% of the profile but was 0% with 33% error

uwsgi is failing, unrelated to PR

r1viollet
r1viollet approved these changes Jan 9, 2026
View reviewed changes
Copy link
Collaborator

@r1viollet r1viollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KowalskiThomas KowalskiThomas merged commit 401db80 into main Jan 12, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@r1viollet r1viollet r1viollet approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@KowalskiThomas @r1viollet